Skip to content

Fix version for importlib_metadata on python 3.7 #7904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2023
Merged

Fix version for importlib_metadata on python 3.7 #7904

merged 1 commit into from
Oct 23, 2023

Conversation

sydney-runkle
Copy link
Contributor

@sydney-runkle sydney-runkle commented Oct 23, 2023 •
edited by pydantic-hooky bot
Loading

Change Summary

Fix importlib_metadata requirement for Python 3.7

Related issue number

Fix #7903

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @Kludex

@sydney-runkle
Copy link
Contributor Author

Please review

@sydney-runkle sydney-runkle added the relnotes-fix Used for bugfixes. label Oct 23, 2023
@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9207930
Status: ✅  Deploy successful!
Preview URL: https://e5bfe5d4.pydantic-docs2.pages.dev
Branch Preview URL: https://fix-req-for-37.pydantic-docs2.pages.dev

View logs

Kludex
Kludex approved these changes Oct 23, 2023
View reviewed changes
@sydney-runkle sydney-runkle merged commit 5be53ce into main Oct 23, 2023
@sydney-runkle sydney-runkle deleted the fix-req-for-37 branch October 23, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kludex Kludex Kludex approved these changes

Assignees

@Kludex Kludex

Labels
ready for review relnotes-fix Used for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

importlib_metadata required but missing for Python 3.7
2 participants
@sydney-runkle @Kludex