Fix display_as_type for TypeAliasType in python 3.12
#7929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
7d2882d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://318367bf.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://remove-typealiastype-xfails.pydantic-docs2.pages.dev |
adriangb
approved these changes
Oct 25, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@adriangb any issues with this? I think you added those xfails, this change seems reasonable to me since it only affects cases which would currently raise an AttributeError when trying to display a type. And the comment I added should be enough to indicate why it was added in case it becomes unnecessary in the future and anyone otherwise wants to remove it.
Related to #7893; if this gets merged then probably the xfail on the test added there will need to be removed before merging (or that xfail will need to be removed as part of this PR if that PR is merged first).