Update to pyright==1.1.335
#8075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viicos
commented
Nov 10, 2023
Viicos
force-pushed
the
update-pyright
branch
from
a8e866a to
a09c02f
Compare
Viicos
force-pushed
the
update-pyright
branch
from
06b51dd to
e81806b
Compare
|
Please review |
sydney-runkle
approved these changes
Nov 10, 2023
dmontagu
reviewed
Nov 10, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Had to fetch new typeshed changes in #6563, and some unrelated errors got catched by latest pyright.
Not really satisfied with issues with
Self(ideally return types should beSelf | FieldInfo, but well..)Checklist
Selected Reviewer: @sydney-runkle