Skip to content

Conversation

samuelcolvin
Copy link
Member

@samuelcolvin samuelcolvin commented Sep 18, 2019

Change Summary

  • Turns out change_exception although elegant, was quite slow.
  • other small improvements to how exceptions are structured

roughly 25% improvement on benchmarks.

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.rst file added describing change
    (see changes/README.md for details)

@codecov
Copy link

codecov bot commented Sep 18, 2019

Codecov Report

Merging #819 into master will decrease coverage by 0.06%.
The diff coverage is 97.46%.

@@            Coverage Diff             @@
##           master     #819      +/-   ##
==========================================
- Coverage     100%   99.93%   -0.07%     
==========================================
  Files          17       17              
  Lines        2989     3023      +34     
  Branches      583      582       -1     
==========================================
+ Hits         2989     3021      +32     
- Misses          0        2       +2
Impacted Files Coverage Δ
pydantic/main.py 100% <100%> (ø) ⬆️
pydantic/types.py 100% <100%> (ø) ⬆️
pydantic/errors.py 100% <100%> (ø) ⬆️
pydantic/datetime_parse.py 100% <100%> (ø) ⬆️
pydantic/utils.py 100% <100%> (ø) ⬆️
pydantic/networks.py 100% <100%> (ø) ⬆️
pydantic/error_wrappers.py 100% <100%> (ø) ⬆️
pydantic/validators.py 99.42% <95.74%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16263ba...fb9d58c. Read the comment docs.

@samuelcolvin samuelcolvin force-pushed the performance-improvements branch from 4833171 to 8f1ea0f Compare September 18, 2019 12:16
@samuelcolvin samuelcolvin merged commit 24ac052 into master Sep 18, 2019
@samuelcolvin samuelcolvin deleted the performance-improvements branch September 18, 2019 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant