Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small bits of cleanup #851

Merged
merged 4 commits into from Oct 1, 2019
Merged

small bits of cleanup #851

merged 4 commits into from Oct 1, 2019

Conversation

samuelcolvin
Copy link
Collaborator

@samuelcolvin samuelcolvin commented Oct 1, 2019

  • rename a few internal things in main.py
  • correct coverage for GetterDict
  • fix user and password properties of AnyUrl

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.rst file added describing change
    (see changes/README.md for details)

@codecov
Copy link

codecov bot commented Oct 1, 2019

Codecov Report

Merging #851 into master will increase coverage by 0.06%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #851      +/-   ##
========================================
+ Coverage   99.93%   100%   +0.06%     
========================================
  Files          17     17              
  Lines        3099   3379     +280     
  Branches      598    756     +158     
========================================
+ Hits         3097   3379     +282     
+ Misses          2      0       -2
Impacted Files Coverage Δ
pydantic/networks.py 100% <ø> (ø) ⬆️
pydantic/main.py 100% <100%> (ø) ⬆️
pydantic/fields.py 100% <0%> (ø) ⬆️
pydantic/env_settings.py 100% <0%> (ø) ⬆️
pydantic/utils.py 100% <0%> (+1.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ce16ed...90978d3. Read the comment docs.

@samuelcolvin samuelcolvin changed the title small tweaks to main.py small bits of cleanup Oct 1, 2019
@samuelcolvin samuelcolvin merged commit 8f29837 into master Oct 1, 2019
11 checks passed
@samuelcolvin samuelcolvin deleted the main-tweaks branch Oct 1, 2019
andreshndz pushed a commit to cuenca-mx/pydantic that referenced this issue Jan 17, 2020
* small tweaks to main.py

* add changes

* correct ModelMetaclass name

* fix password and user on AnyUrl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant