Automatically add no-cover to TYPE_CHECKING blocks #874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed this while working on #873, but assumed it would be better to put it in a separate PR. |
Codecov Report
@@ Coverage Diff @@
## master #874 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 16 16
Lines 2716 2716
Branches 518 518
=====================================
Hits 2716 2716
Continue to review full report at Codecov.
|
|
👍 very clever/how was I too stupid to think of this before? |
4 tasks
andreshndz
pushed a commit
to cuenca-mx/pydantic
that referenced
this pull request
Jan 17, 2020
* Automatically add no-cover to TYPE_CHECKING blocks * Add changes file
alexdrydew
pushed a commit
to alexdrydew/pydantic
that referenced
this pull request
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Adds
if TYPE_CHECKING:to the exclude_lines for coverage so that the# pragma: no covercan be removed everywhere it occurs next to anif TYPE_CHECKING:block.Note: this is safe since code inside such blocks should never be executed except during static analysis.
Checklist
changes/<pull request or issue id>-<github username>.rstfile added describing change(see changes/README.md for details)