Skip to content

Conversation

koxudaxi
Copy link
Contributor

@koxudaxi koxudaxi commented Oct 8, 2019

Change Summary

The PR fixes the field of a type that has a default value.

Related issue number

#878

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)

@codecov
Copy link

codecov bot commented Oct 8, 2019

Codecov Report

Merging #880 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #880   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          16     16           
  Lines        2716   2716           
  Branches      518    518           
=====================================
  Hits         2716   2716

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a0e531...a5de5c9. Read the comment docs.

@koxudaxi koxudaxi changed the title Fix type field with default value Fix field of a type that has a default value Oct 8, 2019
Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM.

@koxudaxi
Copy link
Contributor Author

koxudaxi commented Oct 9, 2019

I have separated the test.

@samuelcolvin samuelcolvin merged commit 46db1ef into pydantic:master Oct 9, 2019
@samuelcolvin
Copy link
Member

great, thank you.

@koxudaxi
Copy link
Contributor Author

koxudaxi commented Oct 9, 2019

Thank you!!

andreshndz pushed a commit to cuenca-mx/pydantic that referenced this pull request Jan 17, 2020
* fix type field

* update changes

* add testcase

* separate test for type fields
alexdrydew pushed a commit to alexdrydew/pydantic that referenced this pull request Dec 23, 2023
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants