deprecate Model.fields for Model.__fields__ #883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelcolvin
changed the title
samuelcolvin
force-pushed
the
deprecate-model-fields
branch
from
0c9d3b8 to
149034e
Compare
Codecov Report
@@ Coverage Diff @@
## master #883 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 16 16
Lines 2716 2720 +4
Branches 518 521 +3
=====================================
+ Hits 2716 2720 +4
Continue to review full report at Codecov.
|
|
|
|
The new usage is more logical to me. |
andreshndz
pushed a commit
to cuenca-mx/pydantic
that referenced
this pull request
Jan 17, 2020
* deprecate Model.fields, use Model.__fields__ * correct docs
alexdrydew
pushed a commit
to alexdrydew/pydantic
that referenced
this pull request
Dec 23, 2023
Co-authored-by: David Hewitt <1939362+davidhewitt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
deprecated the
Model.fieldsproperty, useModel.__fields__insteadChecklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)