Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing deprecated decorators #8877

Merged
merged 1 commit into from Feb 23, 2024
Merged

Add missing deprecated decorators #8877

merged 1 commit into from Feb 23, 2024

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Feb 23, 2024 •
edited by pydantic-hooky bot

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @dmontagu

@Viicos
Copy link
Contributor Author

Viicos commented Feb 23, 2024

Please review

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 23, 2024

CodSpeed Performance Report

Merging #8877 will not alter performance

Comparing Viicos:missing-deprecated-dec (5820cba) with main (9fc5e18)

Summary

✅ 10 untouched benchmarks

@sydney-runkle sydney-runkle added the relnotes-fix Used for bugfixes. label Feb 23, 2024
sydney-runkle
sydney-runkle approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@sydney-runkle sydney-runkle merged commit 16edb69 into pydantic:main Feb 23, 2024
53 of 55 checks passed
@Viicos Viicos deleted the missing-deprecated-dec branch February 23, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Assignees

@dmontagu dmontagu

Labels
ready for review relnotes-fix Used for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Viicos @sydney-runkle @dmontagu