Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TypeAdapter's typing compatible with special forms #8923

Merged
merged 1 commit into from Feb 29, 2024
Merged

Make TypeAdapter's typing compatible with special forms #8923

merged 1 commit into from Feb 29, 2024

Conversation

adriangb
Copy link
Member

@cloudflare-pages Cloudflare Pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 90f5d0b
Status: ✅  Deploy successful!
Preview URL: https://205bc39a.pydantic-docs2.pages.dev
Branch Preview URL: https://type-adapter-typing.pydantic-docs2.pages.dev

View logs

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 29, 2024

CodSpeed Performance Report

Merging #8923 will not alter performance

Comparing type-adapter-typing (90f5d0b) with main (4b31fd7)

Summary

✅ 10 untouched benchmarks

sydney-runkle
sydney-runkle approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for adding the comment as well 👍

@sydney-runkle sydney-runkle added the relnotes-fix Used for bugfixes. label Feb 29, 2024
@sydney-runkle sydney-runkle merged commit 575f473 into main Feb 29, 2024
53 of 54 checks passed
@sydney-runkle sydney-runkle deleted the type-adapter-typing branch February 29, 2024 20:32
@Viicos Viicos mentioned this pull request Apr 3, 2024
Open
13 tasks
@adriangb adriangb mentioned this pull request Apr 4, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydney-runkle sydney-runkle sydney-runkle approved these changes

@samuelcolvin samuelcolvin Awaiting requested review from samuelcolvin

Assignees

@adriangb adriangb

@samuelcolvin samuelcolvin

Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adriangb @sydney-runkle @samuelcolvin