Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change alias precedence to prefer child models #904

merged 3 commits into from Oct 17, 2019


Copy link

@samuelcolvin samuelcolvin commented Oct 16, 2019

Change Summary

Change the precedence of aliases so child model aliases override child aliases,
including use alias_generator

Related issue number

fix #903


  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/ for details)

Copy link

codecov bot commented Oct 16, 2019

Codecov Report

Merging #904 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #904   +/-   ##
  Coverage     100%   100%           
  Files          16     16           
  Lines        2751   2751           
  Branches      523    523           
  Hits         2751   2751
Impacted Files Coverage Δ
pydantic/ 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 806eba3...39fdd7f. Read the comment docs.

Copy link

pypae commented Oct 16, 2019

Wow incredibly fast, thank you for your awesome work!

@samuelcolvin samuelcolvin merged commit ed7b216 into master Oct 17, 2019
11 checks passed
@samuelcolvin samuelcolvin deleted the alias-precedence branch Oct 17, 2019
andreshndz pushed a commit to cuenca-mx/pydantic that referenced this issue Jan 17, 2020
* Change alias precedence to prefer child models

* add docs about alias precedence

* correct change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

2 participants