Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow abstract sets in include and exclude arguments #921

Merged
merged 4 commits into from Oct 23, 2019

Conversation

samuelcolvin
Copy link
Collaborator

@samuelcolvin samuelcolvin commented Oct 22, 2019

Change Summary

Ease the process of migrating to pydantic v1 by allowing abstracts sets (eg. dict keys) in the include and exclude arguments to dict().

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)

@codecov
Copy link

codecov bot commented Oct 22, 2019

Codecov Report

Merging #921 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #921   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          16     16           
  Lines        2799   2836   +37     
  Branches      543    556   +13     
=====================================
+ Hits         2799   2836   +37
Impacted Files Coverage Δ
pydantic/typing.py 100% <ø> (ø) ⬆️
pydantic/utils.py 100% <100%> (ø) ⬆️
pydantic/error_wrappers.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b5adcc...7bbaff3. Read the comment docs.

@samuelcolvin samuelcolvin merged commit bab6970 into master Oct 23, 2019
11 checks passed
@samuelcolvin samuelcolvin deleted the abstract-sets branch Oct 23, 2019
andreshndz pushed a commit to cuenca-mx/pydantic that referenced this issue Jan 17, 2020
* allow abstract sets in include and exclude arguments

* add change

* correct type hints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant