Skip to content

Replace __spec__.parent with __package__ #9331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2024
Merged

Replace __spec__.parent with __package__ #9331

merged 1 commit into from
Apr 28, 2024

Conversation

hramezani
Copy link
Member

Fixes #9221

Also, it is recommended to use __spec__ instead of __package__

@hramezani hramezani added the relnotes-fix Used for bugfixes. label Apr 26, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Apr 26, 2024

CodSpeed Performance Report

Merging #9331 will not alter performance

Comparing replace-package (de0a655) with main (6b992fd)

Summary

✅ 13 untouched benchmarks

@hramezani hramezani mentioned this pull request Apr 26, 2024
Closed
1 task
sydney-runkle
sydney-runkle approved these changes Apr 28, 2024
View reviewed changes
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hramezani,

This looks great!

@sydney-runkle sydney-runkle merged commit 77d5f66 into main Apr 28, 2024
@sydney-runkle sydney-runkle deleted the replace-package branch April 28, 2024 17:49
sydney-runkle pushed a commit that referenced this pull request May 28, 2024
@hramezani @sydney-runkle
Replace __spec__.parent with __package__ (#9331)
451f780
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use of __package__ in pydantic/__init__.py fails if imported from zip
2 participants
@hramezani @sydney-runkle