Provide missing generics for classmethod in create_model
#9338
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Currently the typing for
create_modelleads to unknowns, possibly raising errors for Pyright users. This is becauseclassmethodis a generic class, and we're simply not passing in any generic parameters for it.This PR fixes the Pyright errors here by passing in generics for usages of
classmethodhere. My presumption is that the validator does not have to return the same type as it accepts, but if that assumption is wrong, I can switch this to use generics for first argument/return value. I use...for the second value since it's simply aParamSpec, and we don't really have a way to signify it takes in a singular argument unless we want to switch this to useCallable.Checklist
Selected Reviewer: @samuelcolvin