Make ImportString json schema compatible #9344
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Adds JSON-Schema handler for ImportString which failed to schematize prior to this change. The schema type of importstring is simply string (which gets imported on validation).
There was a test specifically for an exception for this type, which was changed to validate a model containing an importstring type - there is another test already exercising a bad json schema using the same exception type (see https://github.com/pydantic/pydantic/blob/main/tests/test_types.py#L6155), so there does not look to be loss here.
Note: There could be an opportunity to use a regex validation on the string to match something importable, but I left that out of scope here.
Related issue number
Fix #9327
Checklist
Selected Reviewer: @dmontagu