Add testing coverage for pretty_print #9469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #9469 will not alter performanceComparing Summary
|
|
please review |
sydney-runkle
suggested changes
May 21, 2024
pydantic-hooky
bot
added
awaiting author revision
|
Hmph, looks like there are still some errors (tests failing). Once that's resolved, all looks good! |
Viicos
reviewed
May 21, 2024
tests/test_utils.py
Outdated
| metadata={'schema_type': 'any', 'test_id': '42'}, | ||
| serialization=core_schema.simple_ser_schema('bool'), | ||
| ) | ||
| expected_meta_info = "{\n 'type': 'any',\n 'ref': 'meta_schema',\n 'metadata': {'schema_type': 'any', 'test_id': '42'},\n 'serialization': {'type': 'bool'}\n}\n" |
There was a problem hiding this comment.
Maybe multiline strings could be used?
There was a problem hiding this comment.
@Viicos, yep, I think we're just waiting on formatting changes, but otherwise looks good!
There was a problem hiding this comment.
Thanks for the suggestions! I'll go through and get the tests passing in the workflow later today and then re-request review.
There was a problem hiding this comment.
Changes made and checks passed @sydney-runkle
sydney-runkle
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Added test coverage to CoreSchema pretty print utility function
Related issue number
#7656
Checklist
Selected Reviewer: @dmontagu