Skip to content

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented May 21, 2024

Fixes #9461.

No need to tweak the signature as no **values argument is present

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label May 21, 2024
Copy link

codspeed-hq bot commented May 21, 2024

CodSpeed Performance Report

Merging #9480 will not alter performance

Comparing Viicos:plugin-root-model-construct (7a2fd1e) with main (c488508)

Summary

✅ 13 untouched benchmarks

@Viicos Viicos force-pushed the plugin-root-model-construct branch from 5e209a1 to b439811 Compare May 22, 2024 07:26
@Viicos Viicos force-pushed the plugin-root-model-construct branch from b439811 to 7a2fd1e Compare May 22, 2024 07:43
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good fix, thanks!

@sydney-runkle sydney-runkle merged commit bcac9a2 into pydantic:main May 22, 2024
@Viicos Viicos deleted the plugin-root-model-construct branch May 22, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RootModel.model_construct() typing
2 participants