Skip to content

Fix alias documentation #9529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2024
Merged

Fix alias documentation #9529

merged 2 commits into from
May 30, 2024

Conversation

pjvv
Copy link
Contributor

@pjvv pjvv commented May 30, 2024 •
edited
Loading

Change Summary

Fix the note in the Alias documentation.

Related issue number

None.

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review

@pjvv
Copy link
Contributor Author

pjvv commented May 30, 2024

please review

@github-actions github-actions bot added documentation relnotes-fix Used for bugfixes. labels May 30, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented May 30, 2024

CodSpeed Performance Report

Merging #9529 will not alter performance

Comparing pjvv:update-alias-docs (4fac63d) with main (fc87631)

Summary

✅ 13 untouched benchmarks

sydney-runkle
sydney-runkle approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sydney-runkle sydney-runkle enabled auto-merge (squash) May 30, 2024 15:14
@sydney-runkle sydney-runkle merged commit 1f47473 into pydantic:main May 30, 2024
@pjvv pjvv deleted the update-alias-docs branch May 30, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Kludex Kludex

Labels
documentation ready for review relnotes-fix Used for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pjvv @sydney-runkle @Kludex