Skip to content

Conversation

jaymbans
Copy link
Contributor

@jaymbans jaymbans commented May 31, 2024

Change Summary

Added annotated tzinfo example pattern with offset building upon commit #9468

Related issue number

Related to offset discussion issue 8088

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label May 31, 2024
Copy link

codspeed-hq bot commented May 31, 2024

CodSpeed Performance Report

Merging #9531 will not alter performance

Comparing jaymbans:tzinfo_offset_example (faba512) with main (e67524c)

Summary

✅ 13 untouched benchmarks

@jaymbans
Copy link
Contributor Author

Hey @sydney-runkle , this is my PR following our tzinfo conversation with @ChrisPappalardo at PyCon2024. It factors in the offset example from issue #8088

@sydney-runkle sydney-runkle added relnotes-ignore Omit this PR from the release notes. and removed relnotes-fix Used for bugfixes. labels May 31, 2024
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! So excited to see annotated metadata being used in this way! Thanks for your contribution 🚀 !

@sydney-runkle sydney-runkle merged commit cbc342d into pydantic:main May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-ignore Omit this PR from the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants