Skip to content

Conversation

MarcBresson
Copy link
Contributor

@MarcBresson MarcBresson commented May 31, 2024

Change Summary

add reference to TypeAdapter in the nested disciminated unions documentation

Related issue number

relates to #9512

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @sydney-runkle

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label May 31, 2024
@MarcBresson
Copy link
Contributor Author

please review

Copy link

codspeed-hq bot commented May 31, 2024

CodSpeed Performance Report

Merging #9534 will not alter performance

Comparing MarcBresson:main (d7aeba7) with main (f48d03e)

Summary

✅ 13 untouched benchmarks

@sydney-runkle
Copy link
Contributor

@MarcBresson,

Looks great! Thanks so much for your contribution! I've added a few changes just to get our linting and checks to pass!

@sydney-runkle sydney-runkle added relnotes-ignore Omit this PR from the release notes. and removed relnotes-fix Used for bugfixes. labels May 31, 2024
@sydney-runkle sydney-runkle enabled auto-merge (squash) May 31, 2024 19:59
@sydney-runkle sydney-runkle merged commit 00ff77e into pydantic:main May 31, 2024
@MarcBresson
Copy link
Contributor Author

Thank you for your work! You've actually done way more than me.

My next PR is definitely gonna be better than this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review relnotes-ignore Omit this PR from the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants