Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect regex flags in validation and json schema #9591

Merged
merged 11 commits into from
Jun 11, 2024
Merged

Conversation

sydney-runkle
Copy link
Member

Working on #9568

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Jun 6, 2024
Copy link

cloudflare-pages bot commented Jun 6, 2024

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: b4fd519
Status: ✅  Deploy successful!
Preview URL: https://52b445f1.pydantic-docs.pages.dev
Branch Preview URL: https://regex-fix-flags.pydantic-docs.pages.dev

View logs

Copy link

codspeed-hq bot commented Jun 6, 2024

CodSpeed Performance Report

Merging #9591 will not alter performance

Comparing regex-fix-flags (b4fd519) with main (811db73)

Summary

✅ 13 untouched benchmarks

Copy link
Contributor

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fine to me, subject to core changes!

pydantic/json_schema.py Outdated Show resolved Hide resolved
sydney-runkle and others added 3 commits June 10, 2024 08:58
Co-authored-by: David Hewitt <david.hewitt@pydantic.dev>
@sydney-runkle sydney-runkle enabled auto-merge (squash) June 11, 2024 13:05
@sydney-runkle sydney-runkle merged commit 99c6a06 into main Jun 11, 2024
52 checks passed
@sydney-runkle sydney-runkle deleted the regex-fix-flags branch June 11, 2024 13:24
@l-melon
Copy link

l-melon commented Jun 29, 2024

@sydney-runkle Hi, can I ask what meetings.md is used for?

@sydney-runkle
Copy link
Member Author

@l-melon,

Great question, nothing!

@sydney-runkle
Copy link
Member Author

#9824

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants