-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Fix broken Any and TypeVar behaviour #962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #962 +/- ##
======================================
Coverage 100% 100%
======================================
Files 17 17
Lines 3142 3385 +243
Branches 615 767 +152
======================================
+ Hits 3142 3385 +243
Continue to review full report at Codecov.
|
|
@dmontagu please let me know what you think about this. I ended up supporting I guess the documentation needs a new section on this. |
|
This and #969 should go out ASAP as fixes. Do we want to do a new release from master I think we might as well go straight to v1.1 but if anyone has a strong feeling about this, please let me know here. |
|
I think the support for TypeVar constraints/bounds is pretty awesome! I'm in favor of releasing this as 1.1 with the mypy plugin. Considering the full backwards compatibility, I don't think there is a need to make a 1.0.1 release first. But either way is fine with me. I would release the bug fixes prior to dropping non-plugin support for type-checking the |
pydantic has resolved the bug that was breaking 1.0 (pydantic/pydantic#962).
Setting up Travis for testing builds. Will be setting up builds and releases in a separate commit. This change also unpins pydantic since the issue that existed in 1.0 has since been resolved (pydantic/pydantic#962).
* tests for broken Dict behaviour * fix Any, support TypeVar * change type of field.type_ * add docs and example for TypeVar
Change Summary
Nonevalue passed toAnyfieldsTypeVarand thereby un-parameterized collection types, e.g.Dictrather thanDict[Any, Any]Related issue number
fix #961
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)