Fix annotation application logic #9623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying pydantic-docs with
|
| Latest commit: |
37e7348
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6d944a00.pydantic-docs.pages.dev |
| Branch Preview URL: | https://annotation-application-fix.pydantic-docs.pages.dev |
CodSpeed Performance ReportMerging #9623 will not alter performanceComparing Summary
|
|
Please review |
adriangb
approved these changes
Jun 10, 2024
sydney-runkle
commented
Jun 10, 2024
Comment on lines
+190
to
+209
| COMPARISON_VALIDATORS = { | ||
| 'gt': _validators.greater_than_validator, | ||
| 'ge': _validators.greater_than_or_equal_validator, | ||
| 'lt': _validators.less_than_validator, | ||
| 'le': _validators.less_than_or_equal_validator, | ||
| 'multiple_of': _validators.multiple_of_validator, | ||
| 'min_length': _validators.min_length_validator, | ||
| 'max_length': _validators.max_length_validator, | ||
| } | ||
|
|
||
| CONSTRAINT_STR_FROM_ANNOTATED_TYPE = { | ||
| at.Gt: 'gt', | ||
| at.Ge: 'ge', | ||
| at.Lt: 'lt', | ||
| at.Le: 'le', | ||
| at.MultipleOf: 'multiple_of', | ||
| at.MinLen: 'min_length', | ||
| at.MaxLen: 'max_length', | ||
| } | ||
|
|
There was a problem hiding this comment.
This feels excessive - any better ideas?
Comment on lines
+284
to
+287
| if chain_schema_steps: | ||
| chain_schema_steps = [schema] + chain_schema_steps | ||
| return cs.chain_schema(chain_schema_steps) | ||
|
|
There was a problem hiding this comment.
One interesting question here is what happens when you have mixes of constraints that are applied as validator functions vs chain schema additions. This implementation isn't breaking any tests (in fact, fixing bugs), but I could see an argument for considering a pattern for this more carefully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9381
I've been wanting to refactor the logic from #9303 for a while, and this seemed like a good time to do that.
Still working on this, want to generally improve the annotation application.
Selected Reviewer: @adriangb