Skip to content

Conversation

sydney-runkle
Copy link
Contributor

@sydney-runkle sydney-runkle commented Jun 20, 2024

Just updating v1 :)

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Jun 20, 2024
Copy link

cloudflare-workers-and-pages bot commented Jun 20, 2024

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3fb3bd4
Status: ✅  Deploy successful!
Preview URL: https://0894be9b.pydantic-docs.pages.dev
Branch Preview URL: https://v1-10-17-update.pydantic-docs.pages.dev

View logs

Copy link

codspeed-hq bot commented Jun 20, 2024

CodSpeed Performance Report

Merging #9707 will not alter performance

Comparing v1.10.17-update (3fb3bd4) with main (9a4619d)

Summary

✅ 13 untouched benchmarks

…gnore the change bc it was performance focused, and we're not prioritizing that in v1 anymore
@sydney-runkle
Copy link
Contributor Author

sydney-runkle commented Jun 20, 2024

I actually don't think we need to do a patch release for pydantic here, we mostly just needed the fix in v1.10.17 for import stuff - nothing is changing here imports wise.

We can include this in our next minor release, of course :).

@exs-dwoodward, @vfazio just as a heads up :).

@@ -84,7 +84,7 @@ def display_errors(errors: List['ErrorDict']) -> str:


def _display_error_loc(error: 'ErrorDict') -> str:
return ' -> '.join([str(e) for e in error['loc']])
return ' -> '.join(str(e) for e in error['loc'])
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've explained this in a commit message :)

@sydney-runkle sydney-runkle enabled auto-merge (squash) June 20, 2024 14:38
@sydney-runkle sydney-runkle merged commit 68a2747 into main Jun 20, 2024
@sydney-runkle sydney-runkle deleted the v1.10.17-update branch June 20, 2024 15:04
@sydney-runkle sydney-runkle added relnotes-packaging Used for dependency changes. and removed relnotes-fix Used for bugfixes. labels Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-packaging Used for dependency changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants