-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
validate_call type params fix
#9760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploying pydantic-docs with
|
| Latest commit: |
8e76348
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://88a4505b.pydantic-docs.pages.dev |
| Branch Preview URL: | https://validate-call-fix.pydantic-docs.pages.dev |
CodSpeed Performance ReportMerging #9760 will not alter performanceComparing Summary
|
tests/test_validate_call.py
Outdated
| globs, | ||
| ) | ||
| max = globs['max'] | ||
| assert len(max.__type_params__) == 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any way to test that validate_call is actually using/seeing T?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I don't think it is: #7796
Which I think is something we can fix separately with the issue above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but is there a type param in the pydantic schema or something? or is it replaced with Any?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has an arguments schema with an Any for the item type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a sense this PR is a bit silly, bc we're fixing the syntax for something that doesn't work, but it at least sets the stage to get the type params in accessible places.
Closes #9536
Fix #9744