-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Breaking Change: Merge dict type json_schema_extra
#9792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying pydantic-docs with
|
| Latest commit: |
bf139df
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7ddb0c48.pydantic-docs.pages.dev |
| Branch Preview URL: | https://json-schema-extra-final.pydantic-docs.pages.dev |
dict type json_schema_extradict type json_schema_extra
dmontagu
reviewed
Jun 28, 2024
|
Going to wait to merge this until after the v2.8 release (this will take effect in v2.9) |
CodSpeed Performance ReportMerging #9792 will not alter performanceComparing Summary
|
dmontagu
reviewed
Jul 2, 2024
dmontagu
approved these changes
Jul 2, 2024
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
relnotes-change
Used for changes to existing functionality which don't have a better categorization.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9210
Fix #7686
An alternative to #9636 and #7706.
Thanks @nix010 for help with the tests and chatting through some of the changes.