Skip to content

Conversation

sydney-runkle
Copy link
Contributor

Fix #9210
Fix #7686

An alternative to #9636 and #7706.

Thanks @nix010 for help with the tests and chatting through some of the changes.

@sydney-runkle sydney-runkle added the relnotes-change Used for changes to existing functionality which don't have a better categorization. label Jun 28, 2024
@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Jun 28, 2024
Copy link

cloudflare-workers-and-pages bot commented Jun 28, 2024

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: bf139df
Status: ✅  Deploy successful!
Preview URL: https://7ddb0c48.pydantic-docs.pages.dev
Branch Preview URL: https://json-schema-extra-final.pydantic-docs.pages.dev

View logs

@sydney-runkle sydney-runkle removed the relnotes-fix Used for bugfixes. label Jun 28, 2024
@sydney-runkle sydney-runkle requested a review from dmontagu June 28, 2024 18:20
@sydney-runkle sydney-runkle changed the title **Breaking Change**: Merge dict type json_schema_extra Breaking Change: Merge dict type json_schema_extra Jun 28, 2024
@sydney-runkle
Copy link
Contributor Author

Going to wait to merge this until after the v2.8 release (this will take effect in v2.9)

Copy link

codspeed-hq bot commented Jul 2, 2024

CodSpeed Performance Report

Merging #9792 will not alter performance

Comparing json-schema-extra-final (bf139df) with main (3b3a899)

Summary

✅ 13 untouched benchmarks

@sydney-runkle sydney-runkle requested a review from dmontagu July 2, 2024 15:31
@sydney-runkle sydney-runkle enabled auto-merge (squash) July 2, 2024 17:20
@sydney-runkle sydney-runkle merged commit f62d36f into main Jul 2, 2024
@sydney-runkle sydney-runkle deleted the json-schema-extra-final branch July 2, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-change Used for changes to existing functionality which don't have a better categorization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Difference between TypeAdapter().json_schema and BaseModel.model_json_schema Inconsistencies in model_json_schema with custom fields
2 participants