Skip to content

Conversation

a-alexander
Copy link
Contributor

Missing self as first argument in an @field_serializer decorated method. This had me confused for a while and may confuse others too. Simple fix.

Change Summary

Add 'self' as first argument to wrapped method

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Missing self as first argument in an @field_serializer decorated method. This had me confused for a while and may confuse others too. Simple fix.
@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Jul 4, 2024
Copy link

codspeed-hq bot commented Jul 4, 2024

CodSpeed Performance Report

Merging #9848 will not alter performance

Comparing a-alexander:patch-1 (ef7668b) with main (d654a07)

Summary

✅ 13 untouched benchmarks

@sydney-runkle sydney-runkle added documentation and removed relnotes-fix Used for bugfixes. labels Jul 17, 2024
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spectacular, thank you!

@sydney-runkle sydney-runkle merged commit 56f2c35 into pydantic:main Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants