-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Allow WithJsonSchema to inject $refs w/ http or https links
#9863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow WithJsonSchema to inject $refs w/ http or https links
#9863
Conversation
CodSpeed Performance ReportMerging #9863 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I left a few suggestions for a syntax simplification :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a test. Looks great otherwise!
|
|
|
@adriangb, let's touch base on this one early next week as well 👍 |
WithJsonSchema to inject $refs w/ http or https links
|
Great work here! Apologies on the delayed review. Hope you have a great semester! |
Change Summary
Related issue number
fix #9783
Checklist