Skip to content

Prevent type error for exotic BaseModel/RootModel inheritance #9913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 18, 2024
Merged

Prevent type error for exotic BaseModel/RootModel inheritance #9913

merged 5 commits into from
Jul 18, 2024

Conversation

dmontagu
Copy link
Contributor

@dmontagu dmontagu commented Jul 17, 2024 •
edited
Loading

Closes #9861

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Jul 17, 2024
@dmontagu dmontagu mentioned this pull request Jul 17, 2024
Closed
1 task
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jul 17, 2024 •
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1969b08
Status: ✅  Deploy successful!
Preview URL: https://41d003a8.pydantic-docs.pages.dev
Branch Preview URL: https://dmontagu-9861.pydantic-docs.pages.dev

View logs

@dmontagu
Copy link
Contributor Author

@Viicos I guess this is going to conflict with #9480 — but it seems that introduced the bug reported in #9861. I'll do a bit of digging..

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 17, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #9913 will not alter performance

Comparing dmontagu/9861 (1969b08) with main (fc25478)

Summary

✅ 13 untouched benchmarks

@dmontagu
Copy link
Contributor Author

dmontagu commented Jul 17, 2024 •
edited
Loading

Okay I think I may have found a "real" fix now. Still needs to add the test case from #9861 before merging, assuming this passes CI.

@github-actions GitHub Actions
Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic
  mypy.py
Project Total  

This report was generated by python-coverage-comment-action

sydney-runkle
sydney-runkle approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dmontagu!

@sydney-runkle sydney-runkle merged commit 93ced97 into main Jul 18, 2024
@sydney-runkle sydney-runkle deleted the dmontagu/9861 branch July 18, 2024 17:37
@sydney-runkle sydney-runkle mentioned this pull request Jul 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mypy error: incompatible definition of model_construct() in multiple inheritance from BaseModel and RootModel
2 participants
@dmontagu @sydney-runkle