Skip to content

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Jul 22, 2024

Change Summary

Related issue number

Fixes #9909

I'm not fixing #9099 in this one as it probably requires more work on the validation side.

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Jul 22, 2024
Copy link

codspeed-hq bot commented Jul 22, 2024

CodSpeed Performance Report

Merging #9932 will not alter performance

Comparing Viicos:allow-type-annotated (4fd47f8) with main (cc90fb0)

Summary

✅ 13 untouched benchmarks

Comment on lines +1484 to +1485
# Assume `type[Annotated[<typ>, ...]]` is equivalent to `type[<typ>]`:
type_param = _typing_extra.annotated_type(type_param) or type_param
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adriangb, are you ok with this assumption?

If so, then I'm happy to move forward with this PR. Thanks @Viicos!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup I think it's reasonable

Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @Viicos!

@sydney-runkle sydney-runkle merged commit 9a9f5fb into pydantic:main Jul 22, 2024
@Viicos Viicos deleted the allow-type-annotated branch July 22, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: '_AnnotatedAlias' object cannot be converted to 'PyType'
3 participants