Skip to content

Conversation

dmontagu
Copy link
Contributor

Closes #9923

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Jul 22, 2024
Copy link

cloudflare-workers-and-pages bot commented Jul 22, 2024

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3df3e2c
Status: ✅  Deploy successful!
Preview URL: https://990ae201.pydantic-docs.pages.dev
Branch Preview URL: https://dmontagu-9923.pydantic-docs.pages.dev

View logs

Copy link

codspeed-hq bot commented Jul 22, 2024

CodSpeed Performance Report

Merging #9935 will not alter performance

Comparing dmontagu/9923 (3df3e2c) with main (9a9f5fb)

Summary

✅ 13 untouched benchmarks

Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Looks great.

@sydney-runkle
Copy link
Contributor

Hmm, looks like a bunch of mypy tests are failing...

@sydney-runkle
Copy link
Contributor

Could the failing tests be related to #9913?

Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic
  mypy.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@sydney-runkle sydney-runkle merged commit 92f1d51 into main Jul 22, 2024
@sydney-runkle sydney-runkle deleted the dmontagu/9923 branch July 22, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no mypy error when attempting to mutate frozen field
2 participants