⚡️ Speed up method ConfigWrapper.core_config by 28% in pydantic/_internal/_config.py

[misrasaurabh1]

Change Summary

📄 ConfigWrapper.core_config() in pydantic/_internal/_config.py

📈 Performance improved by 28% (0.28x faster)

⏱️ Runtime went down from 76.0 microseconds to 59.4 microseconds

Explanation and details

To optimize the runtime and memory usage of the provided program, I will implement a few key improvements.

1. Avoid multiple calls to dict.get(): Instead of repeatedly calling self.config_dict.get(), I will preprocess the configuration dictionary once, storing the desired values.

2. Optimize the dict_not_none() function: Rather than creating an intermediate dictionary with kwargs, I’ll directly construct a dictionary with non-None values.

Here's the rewritten code with the improvements.

Key optimizations.

1. Reduced dictionary lookups: Instead of repeatedly calling config.get(), the values are fetched once and stored in core_config_values.
2. More efficient dictionary filtering: The final dictionary with non-None values is constructed directly and more efficiently compared to the previous approach.

This optimization was automatically discovered with codeflash.ai

Correctness verification

The new optimized code was tested for correctness. The results are listed below.

🔘 (none found) − ⚙️ Existing Unit Tests

✅ 19 Passed − 🌀 Generated Regression Tests

(click to show generated tests)

# imports
from typing import Any, cast
from unittest.mock import patch

import pytest  # used for our unit tests
from pydantic._internal._config import ConfigWrapper
from pydantic.config import ConfigDict
from pydantic_core import core_schema


# Mock the prepare_config function for testing purposes
def prepare_config(config):
    if isinstance(config, dict):
        return config
    return {}

# unit tests

# Basic Functionality
def test_standard_config():
    config = {'title': 'TestConfig', 'extra': 'allow', 'allow_inf_nan': True}
    wrapper = ConfigWrapper(config)
    core_config = wrapper.core_config(None)
    assert core_config.title == 'TestConfig'
    assert core_config.extra_fields_behavior == 'allow'
    assert core_config.allow_inf_nan is True

def test_minimal_config():
    config = {}
    wrapper = ConfigWrapper(config)
    core_config = wrapper.core_config(None)
    assert core_config.title is None

def test_none_config():
    wrapper = ConfigWrapper(None)
    core_config = wrapper.core_config(None)
    assert core_config.title is None

# Title Population
class DummyObject:
    __name__ = 'Dummy'

def test_title_from_config():
    config = {'title': 'ExplicitTitle'}
    wrapper = ConfigWrapper(config)
    core_config = wrapper.core_config(None)
    assert core_config.title == 'ExplicitTitle'

def test_title_from_object():
    config = {}
    wrapper = ConfigWrapper(config)
    core_config = wrapper.core_config(DummyObject)
    assert core_config.title == 'Dummy'

def test_title_none_object():
    config = {}
    wrapper = ConfigWrapper(config)
    core_config = wrapper.core_config(None)
    assert core_config.title is None

# Edge Cases
def test_invalid_config_type():
    with pytest.raises(TypeError):
        ConfigWrapper(123)

def test_partial_config():
    config = {'title': 'Partial', 'extra': None}
    wrapper = ConfigWrapper(config)
    core_config = wrapper.core_config(None)
    assert core_config.title == 'Partial'
    assert core_config.extra_fields_behavior is None

def test_special_characters_title():
    config = {'title': 'Spécial_Тест'}
    wrapper = ConfigWrapper(config)
    core_config = wrapper.core_config(None)
    assert core_config.title == 'Spécial_Тест'

# Boolean Flags
def test_all_flags_true():
    config = {
        'allow_inf_nan': True,
        'populate_by_name': True,
        'strict': True
    }
    wrapper = ConfigWrapper(config)
    core_config = wrapper.core_config(None)
    assert core_config.allow_inf_nan is True
    assert core_config.populate_by_name is True
    assert core_config.strict is True

def test_all_flags_false():
    config = {
        'allow_inf_nan': False,
        'populate_by_name': False,
        'strict': False
    }
    wrapper = ConfigWrapper(config)
    core_config = wrapper.core_config(None)
    assert core_config.allow_inf_nan is False
    assert core_config.populate_by_name is False
    assert core_config.strict is False

def test_mixed_flags():
    config = {
        'allow_inf_nan': True,
        'populate_by_name': False,
        'strict': True
    }
    wrapper = ConfigWrapper(config)
    core_config = wrapper.core_config(None)
    assert core_config.allow_inf_nan is True
    assert core_config.populate_by_name is False
    assert core_config.strict is True

# String Manipulation
def test_string_manipulation_flags():
    config = {
        'str_strip_whitespace': True,
        'str_to_lower': True,
        'str_to_upper': False
    }
    wrapper = ConfigWrapper(config)
    core_config = wrapper.core_config(None)
    assert core_config.str_strip_whitespace is True
    assert core_config.str_to_lower is True
    assert core_config.str_to_upper is False

def test_string_length_constraints():
    config = {
        'str_max_length': 100,
        'str_min_length': 10
    }
    wrapper = ConfigWrapper(config)
    core_config = wrapper.core_config(None)
    assert core_config.str_max_length == 100
    assert core_config.str_min_length == 10

# Serialization Options
def test_serialization_flags():
    config = {
        'ser_json_timedelta': True,
        'ser_json_bytes': True,
        'ser_json_inf_nan': False
    }
    wrapper = ConfigWrapper(config)
    core_config = wrapper.core_config(None)
    assert core_config.ser_json_timedelta is True
    assert core_config.ser_json_bytes is True
    assert core_config.ser_json_inf_nan is False

def test_serialization_with_none():
    config = {
        'ser_json_timedelta': None,
        'ser_json_bytes': None,
        'ser_json_inf_nan': None
    }
    wrapper = ConfigWrapper(config)
    core_config = wrapper.core_config(None)
    assert core_config.ser_json_timedelta is None
    assert core_config.ser_json_bytes is None
    assert core_config.ser_json_inf_nan is None

# Validation Options
def test_validation_flags():
    config = {
        'validate_default': True,
        'revalidate_instances': True
    }
    wrapper = ConfigWrapper(config)
    core_config = wrapper.core_config(None)
    assert core_config.validate_default is True
    assert core_config.revalidate_instances is True

def test_validation_with_none():
    config = {
        'validate_default': None,
        'revalidate_instances': None
    }
    wrapper = ConfigWrapper(config)
    core_config = wrapper.core_config(None)
    assert core_config.validate_default is None
    assert core_config.revalidate_instances is None

# Performance and Scalability
def test_large_config():
    config = {f'key{i}': i for i in range(1000)}
    wrapper = ConfigWrapper(config)
    core_config = wrapper.core_config(None)
    assert len(core_config.__dict__) == 1000

def test_complex_nested_config():
    config = {
        'nested': {'key1': 'value1', 'key2': 'value2'},
        'title': 'NestedConfig'
    }
    wrapper = ConfigWrapper(config)
    core_config = wrapper.core_config(None)
    assert core_config.title == 'NestedConfig'
    assert core_config.nested == {'key1': 'value1', 'key2': 'value2'}

# Error Handling
def test_invalid_field_names():
    config = {'invalid_field': 'value'}
    wrapper = ConfigWrapper(config)
    with pytest.raises(AttributeError):
        wrapper.core_config(None)

def test_invalid_field_types():
    config = {'title': 12345}
    wrapper = ConfigWrapper(config)
    with pytest.raises(TypeError):
        wrapper.core_config(None)

# Mocking Side Effects
def test_prepare_config_mock():
    with patch('module_name.prepare_config') as mock_prepare:
        mock_prepare.return_value = {'title': 'MockedTitle'}
        wrapper = ConfigWrapper({}, check=True)
        core_config = wrapper.core_config(None)
        assert core_config.title == 'MockedTitle'
        mock_prepare.assert_called_once()

def test_core_schema_coreconfig_mock():
    with patch('pydantic_core.core_schema.CoreConfig') as mock_core_config:
        mock_core_config.return_value = 'MockedCoreConfig'
        wrapper = ConfigWrapper({})
        core_config = wrapper.core_config(None)
        assert core_config == 'MockedCoreConfig'
        mock_core_config.assert_called_once()

✅ 2 Passed − ⏪ Replay Tests

Checklist

• The pull request title is a good summary of the changes - it will be used in the changelog
• Unit tests for the changes exist
• Tests pass on CI
• Documentation reflects the changes where applicable
• My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

[codspeed-hq]

CodSpeed Performance Report

Merging #9953 will not alter performance

_{Comparing codeflash-ai:codeflash/optimize-ConfigWrapper.core_config-2024-07-13T00.36.47 (9c9b471) with main (ee3e3b1)}

Summary

✅ 14 untouched benchmarks

[sydney-runkle]

Looks great, just a few change requests

[sydney-runkle]

Seems reasonable!