Simplify schema generation for uuid, url, and ip types #9975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying pydantic-docs with
|
| Latest commit: |
3b97ab5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://98ff39ba.pydantic-docs.pages.dev |
| Branch Preview URL: | https://uuid-move.pydantic-docs.pages.dev |
sydney-runkle
added
relnotes-performance
CodSpeed Performance ReportMerging #9975 will not alter performanceComparing Summary
|
This was referenced Jul 25, 2024
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
adriangb
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some std types, including
uuid.UUID, various IP address types, andcore_schema.Url/core_schema.MultiHostUrlhad complicated schema application patterns, jumping through annotation hoops that weren't needed.This moves the generation of those schemas to the
_generate_schema.pyfile directly!This results in a minor improvement to the schema build time: https://codspeed.io/pydantic/pydantic/branches/uuid-move