Skip to content

Conversation

sydney-runkle
Copy link
Contributor

@sydney-runkle sydney-runkle commented Jul 25, 2024

Similar to #9975, moving some schema generation that doesn't need to directly handle metadata to _generate_schema.py

Also provides a nice little performance bump: https://codspeed.io/pydantic/pydantic/branches/move-date-stuff. 40 % speedup for the prep annotations function :)

@sydney-runkle sydney-runkle added the relnotes-performance Used for performance improvements. label Jul 25, 2024
@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Jul 25, 2024
Copy link

cloudflare-workers-and-pages bot commented Jul 25, 2024

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6fe59bb
Status: ✅  Deploy successful!
Preview URL: https://9528c8bc.pydantic-docs.pages.dev
Branch Preview URL: https://move-date-stuff.pydantic-docs.pages.dev

View logs

Copy link

codspeed-hq bot commented Jul 25, 2024

CodSpeed Performance Report

Merging #9976 will not alter performance

Comparing move-date-stuff (6fe59bb) with main (e1b0e1b)

Summary

✅ 14 untouched benchmarks

@sydney-runkle
Copy link
Contributor Author

Currently troubleshooting the failed docs tests...

@sydney-runkle sydney-runkle removed the relnotes-fix Used for bugfixes. label Jul 25, 2024
Copy link
Contributor

github-actions bot commented Jul 25, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Member

@adriangb adriangb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff!

@sydney-runkle sydney-runkle enabled auto-merge (squash) July 25, 2024 16:40
@sydney-runkle sydney-runkle merged commit 90e263f into main Jul 25, 2024
@sydney-runkle sydney-runkle deleted the move-date-stuff branch July 25, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-performance Used for performance improvements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants