From b657e30efdb5a76e3c7ea5894c95273df534813c Mon Sep 17 00:00:00 2001 From: Kevin Sheppard Date: Tue, 23 Jan 2018 22:34:45 +0000 Subject: [PATCH] BUG: Fix order of columns in morningstar Columns are ordered chlo --- pandas_datareader/mstar/daily.py | 5 ++--- pandas_datareader/tests/mstar/test_daily.py | 4 ++-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/pandas_datareader/mstar/daily.py b/pandas_datareader/mstar/daily.py index 5cc43066..e02f8009 100644 --- a/pandas_datareader/mstar/daily.py +++ b/pandas_datareader/mstar/daily.py @@ -172,9 +172,8 @@ def _restruct_json(self, symbol, jsondata): bar = pricedata[p] d = next(date_) bardict = { - "Symbol": symbol, "Date": d, "Open": bar[0], "High": bar[1], - "Low": bar[2], - "Close": bar[3] + "Symbol": symbol, "Date": d, "Close": bar[0], "High": bar[1], + "Low": bar[2], "Open": bar[3] } if len(divdata) == 0: pass diff --git a/pandas_datareader/tests/mstar/test_daily.py b/pandas_datareader/tests/mstar/test_daily.py index cc6a2e51..ae1aa650 100644 --- a/pandas_datareader/tests/mstar/test_daily.py +++ b/pandas_datareader/tests/mstar/test_daily.py @@ -38,7 +38,7 @@ def test_mstar(self): start = datetime(2014, 3, 5) end = datetime(2018, 1, 18) df = web.DataReader('MSFT', 'morningstar', start=start, end=end) - assert (df['Close'][-1] == 89.8) + assert (df['Open'][-1] == 89.8) @skip_on_exception(RemoteDataError) def test_get_data_single_symbol(self): @@ -114,7 +114,7 @@ def test_mstar_reader_class(self): dr = MorningstarDailyReader(symbols="GOOG", interval="d") df = dr.read() - assert df.Volume[('GOOG', '2017-12-13')] == 1279659 + assert df.Close[('GOOG', '2017-12-13')] == 1040.61 session = requests.Session()