Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Exception downloading yahoo historical data with adjust_price=True on fix-yahoo branch #342
Exception downloading yahoo historical data with adjust_price=True on fix-yahoo branch
This can be recreated for symbol = 'SRCE' and date range should include Jun 29, 2016
yahooData = pdr.data.get_data_yahoo(symbol, self.start, self.end, adjust_price=True)
It turned out that on yahoo web site the data displayed:
but when you click on the download button you will get:
string 'null' instead of 0.00 or '-'
The solution is to add 'null' in lower case to na_values argument to read_csv in function _read_lines in base.py
I have made this change that is my repository.
created a pull request get a message about conflicts that must be resolved, probably the branch has been modified, can recreate this one for another branch if needed as merge for some reason was for the master not fix-yahoo
referenced this issue
May 24, 2017
pandas-dev/pandas#16471 is scheduled for 0.21.0, Next Major Release.
even if you don't need price adjustment it is still a good idea to remove 'null'
added a commit
Jun 8, 2017
this still looks like an issue after #355
@OlegShteynbuk want to do a PR?