Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alpha Vantage as data source? #389

Closed
gliptak opened this issue Sep 7, 2017 · 14 comments · Fixed by #490

Comments

@gliptak
Copy link
Contributor

@gliptak gliptak commented Sep 7, 2017

https://www.alphavantage.co/documentation/

Requires an API key

@rsvp

This comment has been minimized.

Copy link

@rsvp rsvp commented Sep 7, 2017

Before releasing our own independent solution, we expect to
make a pull request to the pandas_datareader repository:
rsvp/fecon235#7

@stnatter

This comment has been minimized.

Copy link

@stnatter stnatter commented Sep 8, 2017

can only support this. have been using alpha vantage for a while now. Found their API is reliable and the data quality is good.

@rsvp

This comment has been minimized.

Copy link

@rsvp rsvp commented Sep 8, 2017

What is the pandas_datareader policy on requiring the user to get an API key
from the vendor
? Will a pull request be accepted if there was such a requirement?

@gliptak

This comment has been minimized.

Copy link
Contributor Author

@gliptak gliptak commented Sep 8, 2017

There is already precedent with Enigma

https://github.com/pydata/pandas-datareader/blob/master/pandas_datareader/enigma.py

We will request adding them to Travis and ReadTheDocs

#370

@rsvp

This comment has been minimized.

Copy link

@rsvp rsvp commented Sep 8, 2017

Maybe the vendor should be contacted, and be asked to contribute
their Python wrapper compatible within pandas_datareader.
This way the code is most likely to be maintained.

@MichaelWS

This comment has been minimized.

Copy link

@MichaelWS MichaelWS commented Oct 25, 2017

its a free api key. I am not sure if they would write it.

@gliptak

This comment has been minimized.

Copy link
Contributor Author

@gliptak gliptak commented Oct 25, 2017

I didn't find vendor implementation, but there is https://github.com/RomelTorres/alpha_vantage

@RomelTorres

@RomelTorres

This comment has been minimized.

Copy link

@RomelTorres RomelTorres commented Oct 25, 2017

Hello there, I maintain the python wrapper as much as I can, usually the vendor contacts me whenever there is something new, to make sure I update it. I don't think AlphaVantage itself will release a python wrapper for its API call.

@gliptak

This comment has been minimized.

Copy link
Contributor Author

@gliptak gliptak commented Oct 25, 2017

@RomelTorres Might you consider adding your codebase into pandas-datareader? Thanks

@RomelTorres

This comment has been minimized.

Copy link

@RomelTorres RomelTorres commented Oct 26, 2017

@gliptak Hi, I could do it, but how would be the best way to tackle that? Should I add the original library as a dependency and then send a PR to you guys? or should I port the code base only (That'd mean two things to maintain)?.

Also, what do you guys want from alpha vantage, everything? or just the stock information?

BR Romel

@gliptak

This comment has been minimized.

Copy link
Contributor Author

@gliptak gliptak commented Oct 26, 2017

@RomelTorres First a disclaimer, I'm not an member/committer for pandas-datareader.

My understanding is that the preference would be to not rely on a library (here is the current list of dependencies https://github.com/pydata/pandas-datareader/blob/master/setup.py#L28)

After you could consider using pandas-datareader in your projects, allowing to pull in additional data sources.

As for the data types, there is already stock and FX data (at various timeframes) from other sources, but you might be the first with cryptocurrency data :)

I think many users generate technical indicators from the "raw" data.

@davidastephens @jreback Please comment.

Thanks

@addisonlynch

This comment has been minimized.

Copy link
Contributor

@addisonlynch addisonlynch commented Jan 24, 2018

@RomelTorres have you had a chance to look into this? If so, let me know if you'd like any assistance. If not, I have some time to work on it now and was going to base the readers off of your library.

@RomelTorres

This comment has been minimized.

Copy link

@RomelTorres RomelTorres commented Jan 24, 2018

Hi @addisonlynch I haven't had much time to be honest (a lot of projects going on atm) If you want you can base it off mine.
Saludos, Romel

@addisonlynch addisonlynch referenced this issue Feb 19, 2018
4 of 4 tasks complete
@addisonlynch

This comment has been minimized.

Copy link
Contributor

@addisonlynch addisonlynch commented Feb 19, 2018

I created a pull which implements most of the API. There are some questsions/topics for discussion in the comment. Let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.