New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: support OECD datasource #101

Merged
merged 1 commit into from Oct 9, 2015

Conversation

Projects
None yet
3 participants
@sinhrks
Member

sinhrks commented Oct 6, 2015

Would like to move some func from my local repo.

This allows to retrieve data from OECD.

import pandas_datareader.data as web
import datetime
df = web.DataReader('UN_DEN', 'oecd', end=datetime.datetime(2012, 1, 1))
df[['Japan', 'United States']]
# Country         Japan  United States
# Time                                
#2010-01-01  18.387333      11.383460
#2011-01-01  18.995042      11.329488
#2012-01-01  17.972384      11.078848

Currently, test fails in Python 2.6 because I use json's object_pairs_hook. Can I include simplejson as optional dependency, or should choose alternative impl?

@sinhrks sinhrks added the enhancement label Oct 6, 2015

@davidastephens davidastephens added this to the 0.2.1 milestone Oct 7, 2015

@davidastephens

This comment has been minimized.

Member

davidastephens commented Oct 7, 2015

Maybe include simplejson if on python 2.6?

@sinhrks sinhrks force-pushed the sinhrks:oecd branch 5 times, most recently from 2fe2adb to 90cf66f Oct 7, 2015

@davidastephens

This comment has been minimized.

Member

davidastephens commented Oct 8, 2015

Looks good to me. Thanks! Can you add a note to:
https://github.com/pydata/pandas-datareader/blob/master/docs/source/whatsnew/v0.2.0.txt

and we can merge and include in 0.2.0 (expected release on Friday along with Pandas 0.17.0).

@sinhrks sinhrks force-pushed the sinhrks:oecd branch from 90cf66f to 5828be2 Oct 8, 2015

@sinhrks

This comment has been minimized.

Member

sinhrks commented Oct 8, 2015

Thanks for review. Added the release note.

@sinhrks sinhrks modified the milestones: 0.2.0, 0.2.1 Oct 8, 2015

@davidastephens

This comment has been minimized.

Member

davidastephens commented Oct 9, 2015

Thanks!

davidastephens added a commit that referenced this pull request Oct 9, 2015

Merge pull request #101 from sinhrks/oecd
ENH: support OECD datasource

@davidastephens davidastephens merged commit d5a69e0 into pydata:master Oct 9, 2015

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.8%) to 95.283%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sinhrks sinhrks deleted the sinhrks:oecd branch Oct 9, 2015

@femtotrader

This comment has been minimized.

Contributor

femtotrader commented Oct 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment