New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add requests session to Options #122

Merged
merged 1 commit into from Nov 25, 2015

Conversation

Projects
None yet
2 participants
@davidastephens
Member

davidastephens commented Nov 23, 2015

Adds requests session to Options, increases options parsing by 4x by skipping read_html.

@davidastephens davidastephens force-pushed the davidastephens:option_session branch 2 times, most recently from 9e34c4a to af5c9b7 Nov 23, 2015

@femtotrader

This comment has been minimized.

Contributor

femtotrader commented Nov 23, 2015

@davidastephens

This comment has been minimized.

Member

davidastephens commented Nov 23, 2015

Yes, I needed to use it in order to use the requests functions on the test examples.

@davidastephens davidastephens force-pushed the davidastephens:option_session branch from af5c9b7 to 08e1545 Nov 23, 2015

femtotrader added a commit that referenced this pull request Nov 25, 2015

Merge pull request #122 from davidastephens/option_session
ENH: Add requests session to Options

@femtotrader femtotrader merged commit bbe6d6c into pydata:master Nov 25, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 95.264%
Details

@davidastephens davidastephens deleted the davidastephens:option_session branch Nov 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment