New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added `data_source='yahoo-dividends'` option to DataReader. #138

Merged
merged 1 commit into from Dec 10, 2015

Conversation

Projects
None yet
2 participants
@jtkiley
Contributor

jtkiley commented Dec 7, 2015

The existing dividend support pulls dividends as part of actions, but it's often desirable (for me anyway) to have just the dividends (and to pull a large number of symbols). The functionality is already there in YahooDailyReader, and this PR just creates an option that exposes it in DataReader.

@davidastephens

This comment has been minimized.

Member

davidastephens commented Dec 9, 2015

Thanks. Can you add a comment in the release note and reference in the docs?

@davidastephens

This comment has been minimized.

Member

davidastephens commented Dec 9, 2015

Can you also add a test please?

@jtkiley

This comment has been minimized.

Contributor

jtkiley commented Dec 9, 2015

Will do.

@jtkiley jtkiley closed this Dec 9, 2015

@jtkiley jtkiley reopened this Dec 9, 2015

@davidastephens

This comment has been minimized.

Member

davidastephens commented Dec 10, 2015

Perfect, can you please squash and I will merge.

@jtkiley jtkiley force-pushed the jtkiley:master branch from b0d887f to 91e1e71 Dec 10, 2015

@jtkiley

This comment has been minimized.

Contributor

jtkiley commented Dec 10, 2015

Squashed!

@davidastephens

This comment has been minimized.

Member

davidastephens commented Dec 10, 2015

Perfect, thanks for the contribution!

davidastephens added a commit that referenced this pull request Dec 10, 2015

Merge pull request #138 from jtkiley/master
Added `data_source='yahoo-dividends'` option to DataReader.

@davidastephens davidastephens merged commit c0d205e into pydata:master Dec 10, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 96.015%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment