New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add support for Nasdaq symbol list #254

Merged
merged 2 commits into from Nov 14, 2016

Conversation

Projects
None yet
2 participants
@robottwo

robottwo commented Nov 6, 2016

Nasdaq provides a symbol list with all US equities,
listed on the Nasdaq and other exchanges on their
FTP site. This patch adds support for grabbing
that list.

The list isn't very larger (< 1 MB), so we cache it
to RAM within the process the first time we download it.

Daniel Eisner added some commits Nov 6, 2016

Daniel Eisner Daniel Eisner
Add support for Nasdaq symbol list.
Nasdaq provides a symbol list with all US equities,
listed on the Nasdaq and other exchanges on their
FTP site. This patch adds support for grabbing
that list.

The list isn't very larger (< 1 MB), so we cache it
to RAM within the process the first time we download it.
Daniel Eisner Daniel Eisner

@robottwo robottwo changed the title from Add support for Nasdaq symbol list. to ENH: Add support for Nasdaq symbol list Nov 7, 2016

@femtotrader

This comment has been minimized.

Contributor

femtotrader commented Nov 7, 2016

Thanks @robottwo for this contribution.

There is unit tests, documentation.
flake8 is happy...

I'm ok for merging but I will wait about one week before doing this to allow other people to give their feedback about this PR.

Thanks again

@femtotrader femtotrader merged commit 64b062f into pydata:master Nov 14, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.05%) to 87.886%
Details
@femtotrader

This comment has been minimized.

Contributor

femtotrader commented Nov 14, 2016

Thanks again @robottwo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment