New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMPAT for pandas 0.20.0 #304

Merged
merged 1 commit into from May 7, 2017

Conversation

Projects
None yet
4 participants
@jreback
Contributor

jreback commented May 5, 2017

No description provided.

@jreback jreback added this to the 0.3.1 milestone May 5, 2017

@jreback

This comment has been minimized.

Contributor

jreback commented May 5, 2017

so this will all pdr to be imported; we had removed PandasError. However there are still lots of testing stuff that is using 'internal' pandas things. So this needs to change.

@gfyoung any interest in fixing?

@jreback

This comment has been minimized.

Contributor

jreback commented May 5, 2017

@gfyoung

This comment has been minimized.

Contributor

gfyoung commented May 5, 2017

@jreback : I don't fully understand what you wrote. Could you clarify?

@jreback jreback changed the title from COMPAT for padnas 0.20.0 to COMPAT for pandas 0.20.0 May 5, 2017

@jreback

This comment has been minimized.

Contributor

jreback commented May 5, 2017

@gfyoung the test suite here is a) nose, b) uses lots of things we removed from pandas.util.testing. So best case would be to simply convert this to use pytest and use the public things in pandas.testing.

@gfyoung

This comment has been minimized.

Contributor

gfyoung commented May 5, 2017

@jreback : Ah, I see. I can have a look.

@bashtage

This comment has been minimized.

Contributor

bashtage commented May 5, 2017

LGTM

@gfyoung

This comment has been minimized.

Contributor

gfyoung commented May 7, 2017

@jreback : I think it can be done, but I'm going to wait until this PR gets merged

@jreback

This comment has been minimized.

Contributor

jreback commented May 7, 2017

ok, I kind of wanted to have actual tests. But yes this does fix the issues.

@jreback jreback added the bug label May 7, 2017

@jreback jreback force-pushed the remove_pe branch from e6be3d3 to c320a74 May 7, 2017

@jreback jreback merged commit bdcc3f6 into master May 7, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@jreback

This comment has been minimized.

Contributor

jreback commented May 7, 2017

@gfyoung go to it!

@jreback jreback referenced this pull request May 7, 2017

Closed

BUG: zipfile import #281

@gfyoung

This comment has been minimized.

Contributor

gfyoung commented May 7, 2017

@jreback : Travis seems to disagree that all compat issues have been addressed.

@gfyoung

This comment has been minimized.

Contributor

gfyoung commented May 7, 2017

Actually, I see it's probably because api.types does not exist in older version of pandas. Also, any reason that none of the tests install pandas from master ?

@gfyoung

This comment has been minimized.

Contributor

gfyoung commented May 7, 2017

I'm putting up PR to immediately patch api.types failure.

@jreback

This comment has been minimized.

Contributor

jreback commented May 7, 2017

@gfyoung the import works (which was the initial issue). now none of the tests work because
a) no testing on travis of 0.20.1 (don't need master, this is enough)
b) tm.TestCase is relied upon.
c) api.types.

@jreback

This comment has been minimized.

Contributor

jreback commented May 7, 2017

FYI this still uses nose. I think easiest would be to simply change to pytest. (or can just remove tm.TestCase and fix things too)

@gfyoung

This comment has been minimized.

Contributor

gfyoung commented May 7, 2017

@jreback : No, I believe that the test works when the CORRECT version of pandas is installed. However, I don't see why not just patch the api.types failure (condition on pandas version) for the moment.

@gfyoung

This comment has been minimized.

Contributor

gfyoung commented May 7, 2017

no testing on travis of 0.20.1 (don't need master, this is enough)

Why not just add master to allowed failures? Couldn't hurt, could it?

tm.TestCase is relied upon

Well, that will be taken care of when I do the pytest conversion.

@jreback

This comment has been minimized.

Contributor

jreback commented May 7, 2017

Why not just add master to allowed failures? Couldn't hurt, could it?

sure, but have to install from daily wheels (which can do), but easier just to install latest :>

can do it in steps.

@gfyoung

This comment has been minimized.

Contributor

gfyoung commented May 7, 2017

sure, but have to install from daily wheels (which can do), but easier just to install latest

Fair enough. I would prefer to install from daily wheels in the end, though I'm not sure how that is done.

can do it in steps.

Agreed.

@jreback

This comment has been minimized.

Contributor

jreback commented May 7, 2017

https://github.com/pandas-dev/pandas/blob/master/ci/requirements-3.6_NUMPY_DEV.build.sh
except install pandas (and just install numpy first, otherwise I think it will attempt to build it which is bad).

@mrocklin

This comment has been minimized.

mrocklin commented May 15, 2017

When is this likely to be released? I'm running a tutorial on Wednesday that uses this library and want to pin versions. Should I pin 0.20.1 or 0.19?

@jreback

This comment has been minimized.

Contributor

jreback commented May 15, 2017

@jreback jreback modified the milestone: 0.4.0 May 15, 2017

@jreback jreback deleted the remove_pe branch Jun 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment