New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Yahoo iCharts API #355

Merged
merged 24 commits into from Jul 2, 2017

Conversation

Projects
None yet
2 participants
@jreback
Contributor

jreback commented Jul 2, 2017

supersedes #331

closes #315

  • fixes some issues with resources being closed (e.g. the session object).
  • remove deprecations of .ix -> replaced by .loc
  • remove deprecations of .sortlevel -> replaced by .sort_index
  • removes the _testing.py module; instead just uses xfails for RemoteDataException

rgkimball and others added some commits May 17, 2017

Replaces ichart API for single-stock price exports from Yahoo, multi-…
…stock still failing (#315)

Restores change necessary for Google to function
Fixes yahoo-actions per API endpoint update
Update regex pattern for crumbs, per heyuhere's review
'v' is no longer a valid interval value
Fixes Yahoo intervals and cases where the Yahoo cookie could not be extracted.
Implements multi-stock queries to Yahoo API
Adds a pause multiplier for subsequent requests from Yahoo, error handling for empty data requests, and updates some test logic for pandas 0.20.x (notably ix deprecation)
Check object type before checking contents
Replacement regex logic for additional Yahoo cookie token structures, per chris-b1
Improved error handling and refactoring test to best practices, per jreback review.

closes #315
remove deprecation warnings: ix usage -> loc/iloc
remove deprecation warnings: sortlevel usage -> sort_index

@jreback jreback referenced this pull request Jul 2, 2017

Closed

Replace Yahoo iCharts API #331

jreback added some commits Jul 2, 2017

@jreback jreback added this to the 0.5.0 milestone Jul 2, 2017

@jreback jreback added the bug label Jul 2, 2017

@jreback jreback merged commit 6f4a22f into master Jul 2, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on master at 85.529%
Details

gliptak added a commit to gliptak/pandas-datareader that referenced this pull request Jul 4, 2017

Correct tests after pydata#355
Signed-off-by: Gábor Lipták <gliptak@gmail.com>

gliptak added a commit to gliptak/pandas-datareader that referenced this pull request Jul 4, 2017

Correct tests after pydata#355
Signed-off-by: Gábor Lipták <gliptak@gmail.com>

@bashtage bashtage deleted the rgkimball-fix-yahoo branch Jan 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment