New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Issue 376 Update EnigmaReader Data Connector #380

Merged
merged 5 commits into from Oct 22, 2017

Conversation

Projects
None yet
4 participants
@hydrosquall
Contributor

hydrosquall commented Aug 5, 2017

Implements #376, and includes

  • Updating EnigmaReader
  • Updating tests
  • Updating docs
  • Updating the main data.py library.

The exact sunsetting date of app.enigma.io is not determined, but is coming soon.

@hydrosquall hydrosquall force-pushed the hydrosquall:feature/Issue-376-update-enigma-connector branch from e21897b to a034f31 Aug 5, 2017

Cameron Yick

@hydrosquall hydrosquall force-pushed the hydrosquall:feature/Issue-376-update-enigma-connector branch from a034f31 to f79ef9f Aug 5, 2017

@hydrosquall

This comment has been minimized.

Contributor

hydrosquall commented Aug 5, 2017

@jreback , this is ready for review :)

@@ -202,15 +202,18 @@ Available expiry dates can be accessed from the ``expiry_dates`` property.
Enigma
======
Access datasets from `Enigma <https://app.enigma.io>`__,

This comment has been minimized.

@jreback

jreback Aug 6, 2017

Contributor

add a note/warning that this changed in 0.6.0

This comment has been minimized.

@hydrosquall

hydrosquall Aug 6, 2017

Contributor

Updated on line 207

the world's largest repository of structured public data.
Datasets are unique identified by the ``uuid4`` at the end of a dataset's web address.
For example, the following code downloads USDA Food Recall Data from https://public.enigma.com/datasets/292129b0-1275-44c8-a6a3-2a0881f24fe1.

This comment has been minimized.

@jreback

jreback Aug 6, 2017

Contributor

your https won't render, do like: `USDA Food Recal Data <https:.......>`__

This comment has been minimized.

@hydrosquall

hydrosquall Aug 6, 2017

Contributor

Done :)!

@hydrosquall

This comment has been minimized.

Contributor

hydrosquall commented Aug 7, 2017

@jreback , changes are complete! Let me know if you need anything else tweaked

@gliptak

This comment has been minimized.

Contributor

gliptak commented Sep 8, 2017

@jreback Would you like to see other updates to this PR? Thanks

@hydrosquall

This comment has been minimized.

Contributor

hydrosquall commented Oct 4, 2017

@davidastephens - would it be OK to role this PR into the next release?

@hydrosquall

This comment has been minimized.

Contributor

hydrosquall commented Oct 9, 2017

Update: app.enigma.io has just been sunset, and points to public.enigma.com instead. As a result, the old EnigmaDatareader has stopped working, but the new EnigmaDatareader in this PR fixes that.

@davidastephens davidastephens merged commit 87dffc8 into pydata:master Oct 22, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.6%) to 87.927%
Details
@davidastephens

This comment has been minimized.

Member

davidastephens commented Oct 22, 2017

Thanks @hydrosquall

@gliptak gliptak referenced this pull request Oct 22, 2017

Closed

Enigma - JSONDecodeError #406

@hydrosquall hydrosquall deleted the hydrosquall:feature/Issue-376-update-enigma-connector branch Oct 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment