Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kurtforrester base freq #449

Merged
merged 5 commits into from Jan 18, 2018

Conversation

@bashtage
Copy link
Contributor

bashtage commented Jan 18, 2018

  • closes #199
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
Kurt Forrester and others added 5 commits Apr 27, 2016
added `freq` paramter `_BaseReader` and updated `def params` to accomodate monthly frequency data from the World Bank database.
…y and annual data from World Bank.

also added test for monthly and quarterly.
updated if-statement to utilise if-elif-else style
Store freq in base
@bashtage bashtage force-pushed the bashtage:kurtforrester-base-freq branch from f5b3475 to c88c906 Jan 18, 2018
@bashtage bashtage merged commit 3156d71 into pydata:master Jan 18, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+2.0%) to 69.903%
Details
@bashtage bashtage deleted the bashtage:kurtforrester-base-freq branch Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.