New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Morningstar Data #467

Closed
wants to merge 9 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@dtemkin
Contributor

dtemkin commented Jan 22, 2018

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • added entry to docs/source/whatsnew/vLATEST.txt
@classmethod
def setup_class(cls):
pytest.skip('Skip all Morningstar tests.')

This comment has been minimized.

@bashtage

bashtage Jan 22, 2018

Contributor

This is skipping all test. They need to run.

@classmethod
def setup_class(cls):
pytest.skip('Skip all Morningstar tests.')

This comment has been minimized.

@bashtage

bashtage Jan 22, 2018

Contributor

This is skipping all test. They need to run.

@bashtage

This comment has been minimized.

Contributor

bashtage commented Jan 22, 2018

I've worked on this quite a bit on my branch. This is a nice addition but I think it is unfortunately far from ready. The daily reader is a very useful contribution.

Removed Unit Test Skipping
Updated whatsnew/v0.6.0.txt
@dtemkin

This comment has been minimized.

Contributor

dtemkin commented Jan 22, 2018

I saw that you had made changes and I really appreciate the effort. The financials data was beyond tricky because of the way it was formatted. I was having the same feeling that it wasn't ready especially given that I could not figure out how to parse the Growth Key Ratios. Do you think I should I remove the financials component and re-commit? Or were you referring to the daily OHLCV data as well?

@bashtage

This comment has been minimized.

Contributor

bashtage commented Jan 22, 2018

It might help to split the financials from the OHLCV. The OHLCV reader likely has a much larger audience.

OHLCV passes all tests in my branch. The financials still has a few issues.

dtemkin added some commits Jan 22, 2018

Removed Financials
Added web.DataReader interface
Updated whatsnew/v0.6.0.txt

This was referenced Jan 23, 2018

@bashtage

This comment has been minimized.

Contributor

bashtage commented Jan 23, 2018

Thanks for this -- I cleaned it a bit and it was committed today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment