New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parsing latitude and longitude in wb.get_countries #47

Merged
merged 1 commit into from Jun 10, 2015

Conversation

Projects
None yet
2 participants
@stared
Contributor

stared commented May 13, 2015

World Bank provides latitude and longitude as strings (and an empty string as a missing value). It's inconvenient so, I parse it to floats. Additionally, I added some description to the wb.get_countries function.

@davidastephens

This comment has been minimized.

Member

davidastephens commented May 13, 2015

Thanks! Can you add a test?

@stared

This comment has been minimized.

Contributor

stared commented May 13, 2015

Is it what you had in mind?

@davidastephens

This comment has been minimized.

Member

davidastephens commented May 14, 2015

That should work, looks like you just need to import pandas as pd in the test file.

@davidastephens

This comment has been minimized.

Member

davidastephens commented Jun 9, 2015

Looks good - can you rebase and I will merge?

@stared

This comment has been minimized.

Contributor

stared commented Jun 9, 2015

It seams that master didn't change in the meantime: https://github.com/pydata/pandas-datareader/network.

@davidastephens

This comment has been minimized.

Member

davidastephens commented Jun 9, 2015

Sorry, I meant rebase and squash to one commit.

Thanks.

parsing latitude and longitude in wb.get_countries
test for latitude and longitude

pandas instead of pd

@stared stared force-pushed the stared:patch-1 branch from 3c2fe23 to 564d30f Jun 9, 2015

@stared

This comment has been minimized.

Contributor

stared commented Jun 9, 2015

OK, I squashed it all.

davidastephens added a commit that referenced this pull request Jun 10, 2015

Merge pull request #47 from stared/patch-1
BUG: Parsing latitude and longitude in wb.get_countries

@davidastephens davidastephens merged commit 4062317 into pydata:master Jun 10, 2015

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.01%) to 76.95%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@davidastephens

This comment has been minimized.

Member

davidastephens commented Jun 10, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment