Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows user to input a custom base url to EnigmaReader #499

Merged
merged 4 commits into from Apr 13, 2018

Conversation

@EmilRex
Copy link
Contributor

EmilRex commented Mar 7, 2018

Adds support for optionally passing a custom base_url to the EnigmaReader. The default behavior will not change, but this will allow the reader to be used with dev/staging instances as well as custom deployments. The feature will also guard against any further domain changes such as in #376.

@EmilRex EmilRex changed the title Allows user to input a custom enigma base url Allows user to input a custom base url in `EnigmaReader` Mar 7, 2018
@EmilRex EmilRex changed the title Allows user to input a custom base url in `EnigmaReader` Allows user to input a custom base url to EnigmaReader Mar 7, 2018
Emil Christensen
@EmilRex

This comment has been minimized.

Copy link
Contributor Author

EmilRex commented Mar 9, 2018

@bashtage This is ready for review. Happy to fix anything I might have left out and really appreciate the time. :bowtie:

@@ -32,7 +32,8 @@ def __init__(self,
api_key=None,
retry_count=5,
pause=.75,
session=None):
session=None,
base_url="https://public.enigma.com/api"):

This comment has been minimized.

Copy link
@bashtage

bashtage Apr 4, 2018

Contributor

Needs something added to the docstring. Ideally, the docstring would be rewritten to include all parameters.

This comment has been minimized.

Copy link
@EmilRex

EmilRex Apr 4, 2018

Author Contributor

@bashtage Added a Parameters section to the EnigmaReader docstring. Let me know what you think.

Emil Christensen and others added 2 commits Apr 4, 2018
@bashtage bashtage merged commit 8699ddf into pydata:master Apr 13, 2018
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@EmilRex EmilRex deleted the EmilRex:feature/configurable-enigma-url branch Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.