Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMPAT: Add forward compat for is_list_like #520

Merged
merged 1 commit into from Apr 14, 2018

Conversation

@bashtage
Copy link
Contributor

bashtage commented Apr 14, 2018

Pandas 0.23 moves is_list_like
Add import to compat

  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • added entry to docs/source/whatsnew/vLATEST.txt
@bashtage bashtage force-pushed the bashtage:future-pandas branch from d1a54d2 to 512418c Apr 14, 2018
Pandas 0.23 moves is_list_like
Add import to compat
Ignore UnstableAPIWarnings in Google
Swap tslib.Timestamp for Timestamp
@bashtage bashtage force-pushed the bashtage:future-pandas branch from 512418c to 98a52fb Apr 14, 2018
@bashtage bashtage merged commit da18fbd into pydata:master Apr 14, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-3.7%) to 80.996%
Details
@bashtage bashtage deleted the bashtage:future-pandas branch Apr 14, 2018
@kfirbreger

This comment has been minimized.

Copy link

kfirbreger commented May 23, 2018

Its still not fixed. Replacing it as per https://stackoverflow.com/questions/50394873/import-pandas-datareader-gives-importerror-cannot-import-name-is-list-like does seem to work. So:

from pandas.api.types import is_list_like

Would you like a pull request with the change?

@addisonlynch

This comment has been minimized.

Copy link
Contributor

addisonlynch commented May 23, 2018

@kfirbreger @JordanPlatts it was fixed with this PR. Download the dev version per the docs (pip3 install git+https://github.com/pydata/pandas-datareader) and it will work fine.

@pcacentral

This comment has been minimized.

Copy link

pcacentral commented May 31, 2018

To download the recent dev version have not worked, version pandas-datareader 0.6.0+30.g3c17058

Locate fred.py file inside /anaconda3/lib/python3.6/site-packages/pandas_datareader and replace as follows:

from pandas.core.common import is_list_like #REMOVE OR COMMENT OUT

from pandas.api.types import is_list_like #INSERT

uqs pushed a commit to freebsd/freebsd-ports that referenced this pull request Jun 15, 2018
…ins an important fix

It was failing without this fix: pydata/pandas-datareader#520

Approved by:	portmgr (port compliance, infrastructure)


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@472419 35697150-7ecd-e111-bb59-0022644237b5
uqs pushed a commit to freebsd/freebsd-ports that referenced this pull request Jun 15, 2018
…ins an important fix

It was failing without this fix: pydata/pandas-datareader#520

Approved by:	portmgr (port compliance, infrastructure)
swills pushed a commit to swills/freebsd-ports that referenced this pull request Jun 15, 2018
…ins an important fix

It was failing without this fix: pydata/pandas-datareader#520

Approved by:	portmgr (port compliance, infrastructure)


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@472419 35697150-7ecd-e111-bb59-0022644237b5
Jehops pushed a commit to Jehops/freebsd-ports that referenced this pull request Jun 15, 2018
…ins an important fix

It was failing without this fix: pydata/pandas-datareader#520

Approved by:	portmgr (port compliance, infrastructure)


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@472419 35697150-7ecd-e111-bb59-0022644237b5
mat813 pushed a commit to mat813/freebsd-ports that referenced this pull request Jun 15, 2018
…ins an important fix

It was failing without this fix: pydata/pandas-datareader#520

Approved by:	portmgr (port compliance, infrastructure)


git-svn-id: https://svn.freebsd.org/ports/head@472419 35697150-7ecd-e111-bb59-0022644237b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.