Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Bug fix for downloading index historicals. #591

Merged
merged 1 commit into from Dec 5, 2018

Conversation

@corakwue
Copy link
Contributor

corakwue commented Oct 20, 2018

import pandas_datareader.data as web f = web.DataReader('^DJI', 'stooq')

Above code breaks because country code is pre-appended for any symbol. For index data (^dji, ^spx etc), there is no need to pre-append country code. This patch fixes that.

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • added entry to docs/source/whatsnew/vLATEST.txt
`import pandas_datareader.data as web
f = web.DataReader('^DJI', 'stooq')`

Above code breaks because country code is pre-appended for any symbol. For index data (^dji, ^spx etc), there is no need to pre-append country code. This patch fixes that.
@corakwue

This comment has been minimized.

Copy link
Contributor Author

corakwue commented Oct 20, 2018

I checked, the CI build failures appear to be unrelated to the commit.

@bashtage

This comment has been minimized.

Copy link
Contributor

bashtage commented Oct 20, 2018

Could you add a test that uses symbols with all patterns covered by the if then block?

@corakwue

This comment has been minimized.

Copy link
Contributor Author

corakwue commented Oct 20, 2018

Could you add a test that uses symbols with all patterns covered by the if then block?

Done in #592

@addisonlynch

This comment has been minimized.

Copy link
Contributor

addisonlynch commented Dec 5, 2018

@bashtage could you merge these stooq PRs if your review is complete? Lots of issues coming up here and on stack in regards to this problem.

@bashtage bashtage merged commit 6d66ae7 into pydata:master Dec 5, 2018
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@corakwue corakwue deleted the corakwue:patch-1 branch Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.